Re: [Qemu-devel] [PATCH v2 17/17] block: remove support for legecy AES qcow/qcow2 encryption

[Daniel P. Berrange]

On Mon, Feb 08, 2016 at 02:26:54PM -0700, Eric Blake wrote:
> On 01/20/2016 10:38 AM, Daniel P. Berrange wrote:
> > Refuse to use images with the legacy AES-CBC encryption
> > format in the system emulators. They are still fully
> > supported in the qemu-img, qemu-io & qemu-nbd tools in
> > order to allow data to be liberated and for compatibility
> > with older QEMU versions. Continued support in these tools
> > is not a notable burden with the new FDE framework.
> > 
> > Signed-off-by: Daniel P. Berrange <address@hidden>
> > ---
> 
> > +++ b/block/qcow.c
> > @@ -180,6 +180,14 @@ static int qcow_open(BlockDriverState *bs, QDict 
> > *options, int flags,
> >      s->crypt_method_header = header.crypt_method;
> >      if (s->crypt_method_header) {
> >          if (s->crypt_method_header == QCOW_CRYPT_AES) {
> > +            if (bdrv_uses_whitelist()) {
> > +                error_setg(errp,
> > +                           "Use of AES-CBC encrypted qcow images is no 
> > longer "
> > +                           "supported. Please use the qcow2 LUKS format 
> > instead.");
> 
> error_setg() should be a single phrase with no trailing punctuation, not
> two sentences.  Use error_append_hint() for the suggestion of the
> replacement.

Ah, I didn't know that method existed.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|