[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] w32: include winsock2.h before windows.h
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] w32: include winsock2.h before windows.h |
|
Date: |
Tue, 9 Feb 2016 15:37:44 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 09/02/2016 15:28, Peter Maydell wrote:
> On 9 February 2016 at 14:21, Daniel P. Berrange <address@hidden> wrote:
>> > On Tue, Feb 09, 2016 at 03:16:57PM +0100, Paolo Bonzini wrote:
>> > include/qemu/sockets.h also has windows.h included before winsock2.h
>> >
>> > Presumably it didn't cause a failure for you because everything using
>> > sockets.h already pulls in osdep.h. A reason to prune sockets.h
>> > headers perhaps.
> More generally we could prune anything including windows.h manually
> (there are a dozen or so .c and .h files doing that currently).
I honestly do not have time to work on this. :(
Paolo