Re: [Qemu-devel] [PULL 31/32] MAINTAINERS: add all-match entry for qemu-devel@

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> On 09/02/2016 14:47, Markus Armbruster wrote:
>>> >                                                The fallback now relies
>>> > on finding a real person in MAINTAINERS, not just a mailing list for
>> ... in fact all lists now are.  Entries with L: and without M:
>> 
>>     Maintained: LINUX, POSIX, i386 target
>>     Odd fixes: GDB stub
>>     Orphan: Gumstix, Mipssim, Stable 0.10, Stable 0.14, Stable 0.15
>
> Not Stable 0.15 actually.

Oops, it's Stable 1.0.

>> For these, we now fall back to git.  Intentional?
>
> Yes, intentional.  They are other instances of qemu-devel@ or, for
> Gumstix, address@hidden  For some of them it may make sense to give them an
> M too, for stable versions we probably should drop them.
>
>> If yes, mention it in the commit message.
>
> It is mentioned.  For gumstix, it says sub-community right after where
> you cut it. :) "The fallback now relies on finding a real person in
> MAINTAINERS, not just a mailing list for the relevant sub-community".

Yes, that sentence technically covers it, but I find the paragraph
confusing all the same.  Two ways to get my R-by:

1. Split the patch in two: part 1 is the get_maintainer.pl modification,
   part 2 is the MAINTAINERS update.  Each part does just one thing
   then, which allows simple commit messages.  That's what I'd do.

2. Keep the patch as is, but improve the commit message.  Here's my try:

    MAINTAINERS: Fall back to git unless we have a human, add qemu-devel@

    From: Stephen Warren <address@hidden>

    Add an entry to MAINTAINERS that matches every patch, and requests the
    user send patches to address@hidden

    It's not 100% obvious to project newcomers that all patches should
    be sent there; get_maintainer.pl doesn't say so, and since it
    mentions other lists to CC, the wording "the list" from the
    SubmitAPatch wiki page can be taken to mean only those lists, not
    the main list too.

    The F: entries were taken from a similar entry in the Linux kernel.

    On its own, this would break fallback to git, because now every file
    has a maintainer of sorts.  Modify get_maintainer.pl so that mailing
    lists (L: lines) no longer prevent the fallback, only humans (M:
    entries).  This portion of the patch was suggested by
    address@hidden

    Several pre-existing entries have a list but no human.  These now
    fall back to git.  That's a feature.

    Cc: Paolo Bonzini <address@hidden>
    Cc: Markus Armbruster <address@hidden>
    Cc: John Snow <address@hidden>
    Signed-off-by: Stephen Warren <address@hidden>
    Message-Id: <address@hidden>
    [Commit message tweaked]
    Signed-off-by: Paolo Bonzini <address@hidden>
    Reviewed-by: Markus Armbruster <address@hidden>

In addition, consider changing the "All patches CC here" line to "All
patches must be sent to this mailing list".

> For others, there's no reason why it should be different from the
> catch-all entry.
>
>> If no, the easiest fix is to give them an M, if we can find a willing
>> victim.
>> 
>> Aside: we also have entries with neither L: nor M:
>> 
>>     Orphan: LSI53C895A, M68K, an5206, dummy_m68k, mcf5208
>> 
>> Odd.
>
> Not too odd considering they're Orphan. :)  In fact the above entries
> could have their L removed too (apart from Gumstix again).
>
> Paolo