[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] iotests: Update test 139 after the changes
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/3] iotests: Update test 139 after the changes in x-blockdev-del |
|
Date: |
Tue, 9 Feb 2016 08:36:31 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 02/08/2016 07:14 AM, Alberto Garcia wrote:
> Now that we allow x-blockdev-del to work in a new scenario that
> previously forbidden we must update the iotests in order to reflect
> this change.
>
> Both testAttachMedia() and testSnapshot() are splitted in two: one
s/splitted/split/ (one of those weird English words whose past tense is
identical to present tense)
> version keeps the previous behavior, and a second version checks that
> the new functionality works as expected.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> tests/qemu-iotests/139 | 30 +++++++++++++++++++++++++-----
> tests/qemu-iotests/139.out | 4 ++--
> 2 files changed, 27 insertions(+), 7 deletions(-)
Does the test fail if 1/3 is applied in isolation? If so, then this
patch must be squashed with that one.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature