Re: [Qemu-devel] [PATCH 00/14] More #include cleanups

[Eric Blake]

On 02/09/2016 09:08 AM, Eric Blake wrote:
> On 02/09/2016 08:24 AM, Peter Maydell wrote:
>> This set of patches does a bunch more cleaning of includes.
>> Specifically it does everything necessary to be able to
>> remove osdep.h includes from header files including qemu-common.h
>>
>> Most of these patches are small, except for the one which
>> deals with tests/ (that one has already been reviewed).
>> There are several patches which fix code generators to
>> generate correct #includes, and some which do manual changes
>> to C++ or other files that Coccinelle barfs on.
>>
>> The "all:" patch is running clean-includes on the whole
>> tree to pick up some new files which have been added
>> recently (mostly via target-arm).
>>
>> I've thrown in a couple of patches that have already appeared
>> on list, just to get the whole set into one series.
>>
>> I have some pending patches which:
>>  * enhance clean-includes to handle header files
>>  * clean up header files
>>  * add a --all option to clean-includes to do a "run clean
>>    on whole tree"
>>
>> but I'd like to get the "add missing includes to .c files"
>> parts into master before moving onto "remove includes from .h
>> files" part...
> 
> Reviewed-by: Eric Blake <address@hidden>

But failed testing:

  CC    disas/arm.o
  CXX   disas/arm-a64.o
In file included from /usr/include/c++/5.3.1/cmath:41:0,
                 from /home/eblake/qemu-tmp/disas/libvixl/vixl/utils.h:31,
                 from
/home/eblake/qemu-tmp/disas/libvixl/vixl/a64/disasm-a64.h:31,
                 from disas/arm-a64.cc:25:
/usr/include/c++/5.3.1/x86_64-redhat-linux/bits/c++config.h:1991:10:
error: expected unqualified-id before ‘namespace’
   inline namespace __cxx11 __attribute__((__abi_tag__ ("cxx11"))) { }
          ^

Not sure what went wrong there, but 3/14 probably needs tweaking.


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature