[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/1] vl: fix tracing initialization
From: |
Denis V. Lunev |
Subject: |
[Qemu-devel] [PATCH 1/1] vl: fix tracing initialization |
Date: |
Tue, 9 Feb 2016 19:49:05 +0300 |
we should call trace_init_backends() before trace_init_file() for
CONFIG_TRACE_SIMPLE There is no difference for other cases.
This problem was introduced by the commit
commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f
Author: Paolo Bonzini <address@hidden>
Date: Thu Jan 7 16:55:24 2016 +0300
trace: split trace_init_file out of trace_init_backends
'make check' was failed as a result if configured with
--enable-trace-backends=simple
Spotted by Alex Bennée.
Signed-off-by: Denis V. Lunev <address@hidden>
CC: Alex Bennée <address@hidden>
CC: Paolo Bonzini <address@hidden>
CC: Stefan Hajnoczi <address@hidden>
---
vl.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index c581e39..ffaf8b7 100644
--- a/vl.c
+++ b/vl.c
@@ -4098,6 +4098,9 @@ int main(int argc, char **argv, char **envp)
exit(0);
}
+ if (!trace_init_backends()) {
+ exit(1);
+ }
trace_init_file(trace_file);
/* Open the logfile at this point and set the log mask if necessary.
@@ -4118,10 +4121,6 @@ int main(int argc, char **argv, char **envp)
qemu_set_log(0);
}
- if (!trace_init_backends()) {
- exit(1);
- }
-
/* If no data_dir is specified then try to find it relative to the
executable path. */
if (data_dir_idx < ARRAY_SIZE(data_dir)) {
--
2.5.0
- [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization,
Denis V. Lunev <=