Re: [Qemu-devel] [PATCH 00/14] More #include cleanups

[Peter Maydell]

On 9 February 2016 at 16:21, Peter Maydell <address@hidden> wrote:
> On 9 February 2016 at 16:11, Eric Blake <address@hidden> wrote:
>> But failed testing:
>>
>>   CC    disas/arm.o
>>   CXX   disas/arm-a64.o
>> In file included from /usr/include/c++/5.3.1/cmath:41:0,
>>                  from /home/eblake/qemu-tmp/disas/libvixl/vixl/utils.h:31,
>>                  from
>> /home/eblake/qemu-tmp/disas/libvixl/vixl/a64/disasm-a64.h:31,
>>                  from disas/arm-a64.cc:25:
>> /usr/include/c++/5.3.1/x86_64-redhat-linux/bits/c++config.h:1991:10:
>> error: expected unqualified-id before ‘namespace’
>>    inline namespace __cxx11 __attribute__((__abi_tag__ ("cxx11"))) { }
>>           ^
>>
>> Not sure what went wrong there, but 3/14 probably needs tweaking.
>
> Weird. Your machine does compile libvixl right in current master?
> The patch does build fine for me, and it's not clear to me why
> moving the disasm-a64.h include below osdep.h and disas/bfd.h
> would make it stop building. Google suggests that missing
> semicolons can provoke this kind of error so maybe there's
> a latent error in the headers somewhere :-(
>
> I'll have a look and see if clang produces an error and if so
> a more comprehensible one.

Nope, can't repro any kind of compile failure with clang either
on my system. Can I ask you to investigate a bit?

If we just add the osdep.h include but leave the "vixl/a64/disasm-a64.h"
include as the first one in arm-a64.cc does it build OK?
(Maybe our attempts to be first-header clash with the desire
of vixl code to have disas/libvixl/vixl/globals.h be
first-header, though it's not clear to me how.)

thanks
-- PMM