[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_nex
From: |
Leon Alrae |
Subject: |
Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit |
Date: |
Wed, 10 Feb 2016 17:29:16 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 10/02/16 14:11, Paolo Bonzini wrote:
> The last two arguments to these functions are the last and first bit to
> check relative to the base. The code was using incorrectly the first
> bit and the number of bits. Fix this in cpu_physical_memory_get_dirty
> and cpu_physical_memory_all_dirty. This requires a few changes in the
> iteration; change the code in cpu_physical_memory_set_dirty_range to
> match.
>
> Fixes: 5b82b70
> Cc: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> include/exec/ram_addr.h | 55
> ++++++++++++++++++++++++++++++++-----------------
> 1 file changed, 36 insertions(+), 19 deletions(-)
It fixes the performance problem I was seeing:
Tested-by: Leon Alrae <address@hidden>
Thanks,
Leon