Re: [Qemu-devel] [PATCH v6 2/4] trace: Remove unnecessary intermediate event copies

[Lluís Vilanova]

Lluís Vilanova writes:

> The current code forces the use of a chain of ".original" dereferences,
> which looks odd.

> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
>  scripts/tracetool/__init__.py        |    4 +---
>  scripts/tracetool/format/events_h.py |    4 ++--
>  scripts/tracetool/format/tcg_h.py    |    4 ++--
>  3 files changed, 5 insertions(+), 7 deletions(-)

> diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
> index 0663e7f..1bf9246 100644
> --- a/scripts/tracetool/__init__.py
> +++ b/scripts/tracetool/__init__.py
> @@ -6,7 +6,7 @@ Machinery for generating tracing-related intermediate files.
>  """
 
>  __author__     = "Lluís Vilanova <address@hidden>"
> -__copyright__  = "Copyright 2012-2014, Lluís Vilanova <address@hidden>"
> +__copyright__  = "Copyright 2012-2016, Lluís Vilanova <address@hidden>"
>  __license__    = "GPL version 2 or (at your option) any later version"
 
>  __maintainer__ = "Stefan Hajnoczi"
> @@ -287,8 +287,6 @@ def _read_events(fobj):
>                      event.args):
>                  if atrans == aorig:
>                      args_trans.append(atrans)
> -            event_trans.args = Arguments(args_trans)
> -            event_trans = event_trans.copy()
 
>              event_exec = event.copy()
>              event_exec.name += "_exec"

I've detected an error in this piece. Please ignore this patch until v7.


Thanks,
  Lluis