[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] msix: fix msix_vector_masked
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] msix: fix msix_vector_masked |
|
Date: |
Mon, 15 Feb 2016 20:54:50 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
"Michael S. Tsirkin" <address@hidden> writes:
> commit 428c3ece97179557f2753071fb0ca97a03437267 ("fix MSI injection on Xen")
> inadvertently enabled the xen-specific logic unconditionally.
> Limit it to only when xen is enabled.
> Additionally, msix data should be read with pci_get_log
> since the format is pci little-endian.
>
> Reported-by: "Daniel P. Berrange" <address@hidden>
> Cc: Stefano Stabellini <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
Fixes ivshmem-test /x86_64/ivshmem/server-msi. Not run by "make check"
unless you add SPEED=slow. Quick reproducer:
$ make tests/ivshmem-test &&
QTEST_QEMU_BINARY='x86_64-softmmu/qemu-system-x86_64' QTEST_QEMU_IMG=qemu-img
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} gtester -k --verbose
-m slow tests/ivshmem-test
Adding this to the commit message wouldn't hurt.
Thanks!