qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and b


From: Changlong Xie
Subject: Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()
Date: Tue, 16 Feb 2016 14:05:07 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 02/09/2016 01:06 AM, Alberto Garcia wrote:
On Fri 22 Jan 2016 09:02:10 PM CET, "Dr. David Alan Gilbert" <address@hidden> 
wrote:

In general, what do you do to make sure that the data in a new
Quorum child is consistent with that of the rest of the array?

Quorum can have more than one child when it starts. But we don't
do the similar check. So I don't think we should do such check
here.

Yes, but when you start a VM you can verify in advance that all
members of the Quorum have the same data. If you do that on a
running VM how can you know if the new disk is consistent with the
others?

User error if it is not.  Just the same as it is user error if you
request a shallow drive-mirror but the destination is not the same
contents as the backing file.  I don't think qemu has to protect us
from user error in this case.

But the backing file is read-only so the user can guarantee that the
destination has the same data before the shallow mirror. How do you
do that in this case?

I think in the colo case they're relying on doing a block migrate to
synchronise the remote disk prior to switching into colo mode.

Yes but this is a general API that can be used independently from
COLO. I'd say if we want to allow that we should at least place a big
warning in the documentation.


Ok, that's fair enough. Will add in next version.

Thanks
        -Xie
Berto


.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]