[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 04/14] block: Add blk_name_taken()
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v3 04/14] block: Add blk_name_taken() |
Date: |
Wed, 17 Feb 2016 11:29:32 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 16.02.2016 um 19:08 hat Max Reitz geschrieben:
> There may be BlockBackends which are not returned by blk_by_name(), but
> do exist and have a name.
Really? And if so, isn't this a bug?
I expect that a BB is always either visible to the user and has a name
that is resolved to this BB everywhere, or it's entirely internal and
doesn't need a name therefore.
Having a BB that is internal and therefore invisble, but has a name and
prevents the creation of another BB or BDS with the same name, must
certainly be confusing for the user.
> blk_name_taken() allows testing whether a
> specific name is in use already, independent of whether the BlockBackend
> with that name is accessible through blk_by_name().
>
> Signed-off-by: Max Reitz <address@hidden>
Kevin
- [Qemu-devel] [PATCH v3 00/14] blockdev: Further BlockBackend work, Max Reitz, 2016/02/16
- [Qemu-devel] [PATCH v3 02/14] block: Use blk_next() where appropriate, Max Reitz, 2016/02/16
- [Qemu-devel] [PATCH v3 01/14] monitor: Use BB list for BB name completion, Max Reitz, 2016/02/16
- [Qemu-devel] [PATCH v3 03/14] block: Add blk_all_next(), Max Reitz, 2016/02/16
- [Qemu-devel] [PATCH v3 04/14] block: Add blk_name_taken(), Max Reitz, 2016/02/16
- Re: [Qemu-devel] [PATCH v3 04/14] block: Add blk_name_taken(),
Kevin Wolf <=
- [Qemu-devel] [PATCH v3 06/14] block: Use blk_{commit, flush}_all() consistently, Max Reitz, 2016/02/16
- [Qemu-devel] [PATCH v3 08/14] blockdev: Remove blk_hide_on_behalf_of_hmp_drive_del(), Max Reitz, 2016/02/16
- [Qemu-devel] [PATCH v3 05/14] block: Add blk_commit_all(), Max Reitz, 2016/02/16
- [Qemu-devel] [PATCH v3 09/14] block: Move some bdrv_*_all() functions to BB, Max Reitz, 2016/02/16