Re: [Qemu-devel] [PATCH 2/4] s390x/css: Allocate channel_subsys statically

[Eduardo Habkost]

On Wed, Feb 17, 2016 at 12:43:13PM +0100, Cornelia Huck wrote:
> On Tue, 16 Feb 2016 18:59:05 -0200
> Eduardo Habkost <address@hidden> wrote:
> 
> > There's no need to use g_malloc0() to allocate the channel_subsys
> > struct, just use a static variable.
> 
> The original intention was to model that dynamically somehow, but I
> don't see that happening anytime soon, so we can just keep it simple.
> 
> > 
> > Cc: Cornelia Huck <address@hidden>
> > Cc: Christian Borntraeger <address@hidden>
> > Cc: Richard Henderson <address@hidden>
> > Cc: Alexander Graf <address@hidden>
> > Signed-off-by: Eduardo Habkost <address@hidden>
> > ---
> >  hw/s390x/css.c | 177 
> > ++++++++++++++++++++++++++++-----------------------------
> >  1 file changed, 88 insertions(+), 89 deletions(-)
> 
> Seems fine.
> 
> Should this go through the s390x tree, or will it go through another
> tree together with the other patches? In any case, have a
> 
> Reviewed-by: Cornelia Huck <address@hidden>

Thanks!

I was planning to merge it through the (to be created)
machine-core tree. But it may take some days until I can do that,
so feel free to merge patches 2-3 through the s390x tree if you
want to.

-- 
Eduardo