Re: [Qemu-devel] [PATCH 01/13] msix: make msix_clr_pending() visible for clients

[Michael S. Tsirkin]

On Thu, Feb 18, 2016 at 12:07:22PM +0200, Leonid Bloch wrote:
> From: Dmitry Fleytman <address@hidden>
> 
> This function will be used by e1000e device code.
> 
> Signed-off-by: Dmitry Fleytman <address@hidden>
> Signed-off-by: Leonid Bloch <address@hidden>

Reviewed-by: Michael S. Tsirkin <address@hidden>

> ---
>  hw/pci/msix.c         | 2 +-
>  include/hw/pci/msix.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/pci/msix.c b/hw/pci/msix.c
> index eb4ef11..cce89d9 100644
> --- a/hw/pci/msix.c
> +++ b/hw/pci/msix.c
> @@ -72,7 +72,7 @@ void msix_set_pending(PCIDevice *dev, unsigned int vector)
>      *msix_pending_byte(dev, vector) |= msix_pending_mask(vector);
>  }
>  
> -static void msix_clr_pending(PCIDevice *dev, int vector)
> +void msix_clr_pending(PCIDevice *dev, int vector)
>  {
>      *msix_pending_byte(dev, vector) &= ~msix_pending_mask(vector);
>  }
> diff --git a/include/hw/pci/msix.h b/include/hw/pci/msix.h
> index 72e5f93..048a29d 100644
> --- a/include/hw/pci/msix.h
> +++ b/include/hw/pci/msix.h
> @@ -29,6 +29,7 @@ int msix_present(PCIDevice *dev);
>  
>  bool msix_is_masked(PCIDevice *dev, unsigned vector);
>  void msix_set_pending(PCIDevice *dev, unsigned vector);
> +void msix_clr_pending(PCIDevice *dev, int vector);
>  
>  int msix_vector_use(PCIDevice *dev, unsigned vector);
>  void msix_vector_unuse(PCIDevice *dev, unsigned vector);
> -- 
> 2.5.0