Re: [Qemu-devel] [PATCH v7 00/11] Add basic "detach" support for dump-guest-memory

[Paolo Bonzini]

On 18/02/2016 06:16, Peter Xu wrote:
> Changes from v7:
> - patch 8: use s->dump_info.page_size not TARGET_PAGE_SIZE
> - patch 10: change DUMP_STATUS_MAX to DUMP_STATUS__MAX (this is to
>   fix compile error for rebasing to latest master branch, still do
>   not know why we need this change from generating "_MAX" to
>   "__MAX" for enum types...)

It's because otherwise 'max' wouldn't be a valid value for an enum. :)

Paolo

> Changes from v6:
> - patch 9: fix leak of local_err due to patch switch.. [Fam]
> - patch 10: assert "result" before use [Fam]
> - patch 11: add Fam's reviewed-by.
> 
> For older patch, please refers to v6 series:
> 
> https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg01299.html
> 
> Peter Xu (11):
>   dump-guest-memory: cleanup: removing dump_{error|cleanup}().
>   dump-guest-memory: add "detach" flag for QMP/HMP interfaces.
>   dump-guest-memory: using static DumpState, add DumpStatus
>   dump-guest-memory: add dump_in_progress() helper function
>   dump-guest-memory: introduce dump_process() helper function.
>   dump-guest-memory: disable dump when in INMIGRATE state
>   dump-guest-memory: add "detach" support
>   DumpState: adding total_size and written_size fields
>   Dump: add qmp command "query-dump"
>   Dump: add hmp command "info dump"
>   dump-guest-memory: add qmp event DUMP_COMPLETED
> 
>  docs/qmp-events.txt             |  18 ++++
>  dump.c                          | 215 
> ++++++++++++++++++++++++++++++----------
>  hmp-commands-info.hx            |  14 +++
>  hmp-commands.hx                 |   5 +-
>  hmp.c                           |  26 ++++-
>  hmp.h                           |   1 +
>  include/qemu-common.h           |   4 +
>  include/sysemu/dump.h           |  15 +++
>  include/sysemu/memory_mapping.h |   4 +
>  memory_mapping.c                |   3 +
>  qapi-schema.json                |  56 ++++++++++-
>  qapi/event.json                 |  16 +++
>  qmp-commands.hx                 |  31 +++++-
>  qmp.c                           |  14 +++
>  14 files changed, 359 insertions(+), 63 deletions(-)
>