[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 14/15] qapi: Delete visit_start_union(), gen
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v11 14/15] qapi: Delete visit_start_union(), gen_visit_implicit_struct() |
Date: |
Thu, 18 Feb 2016 18:12:03 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 02/18/2016 09:52 AM, Markus Armbruster wrote:
>> Eric Blake <address@hidden> writes:
>>
>>> Delete code rendered dead in the previous patch. As explained
>>> there, we no longer have any need to use visit_start_struct(),
>>> and we no longer have any more code trying to create or use
>>> visit_type_implicit_FOO().
>>>
>>> Signed-off-by: Eric Blake <address@hidden>
>>
>> The previous patch might be simple enough to permit squashing this one
>> in. Your choice.
>>
>
> 13/15:
> 6 files changed, 24 insertions(+), 42 deletions(-)
> 14/15:
> 5 files changed, 66 deletions(-)
>
> Yeah, squashing them makes for a more impressive diffstat, while still
> not being too overwhelming with too much done in one patch. I'm
> assuming you could handle the squashing as part of promoting to your
> qapi-next, if you want?
Can do.
- Re: [Qemu-devel] [PATCH v11 06/15] qapi: Visit variants in visit_type_FOO_fields(), (continued)
[Qemu-devel] [PATCH v11 10/15] qapi: Emit structs used as variants in topological order, Eric Blake, 2016/02/18
[Qemu-devel] [PATCH v11 09/15] qapi: Adjust layout of FooList types, Eric Blake, 2016/02/18
[Qemu-devel] [PATCH v11 14/15] qapi: Delete visit_start_union(), gen_visit_implicit_struct(), Eric Blake, 2016/02/18
[Qemu-devel] [PATCH v11 08/15] qapi-visit: Less indirection in visit_type_Foo_fields(), Eric Blake, 2016/02/18
[Qemu-devel] [PATCH v11 11/15] qapi-visit: Use common idiom in gen_visit_fields_decl(), Eric Blake, 2016/02/18
[Qemu-devel] [PATCH v11 12/15] qapi: Don't box struct branch of alternate, Eric Blake, 2016/02/18
[Qemu-devel] [PATCH v11 13/15] qapi: Don't box branches of flat unions, Eric Blake, 2016/02/18
Re: [Qemu-devel] [PATCH v11 00/15] prune some QAPI visitor cruft (was qapi cleanups subset E), Markus Armbruster, 2016/02/18