qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v11 14/15] qapi: Delete visit_start_union(), gen


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v11 14/15] qapi: Delete visit_start_union(), gen_visit_implicit_struct()
Date: Thu, 18 Feb 2016 18:12:03 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 02/18/2016 09:52 AM, Markus Armbruster wrote:
>> Eric Blake <address@hidden> writes:
>> 
>>> Delete code rendered dead in the previous patch.  As explained
>>> there, we no longer have any need to use visit_start_struct(),
>>> and we no longer have any more code trying to create or use
>>> visit_type_implicit_FOO().
>>>
>>> Signed-off-by: Eric Blake <address@hidden>
>> 
>> The previous patch might be simple enough to permit squashing this one
>> in.  Your choice.
>> 
>
> 13/15:
>  6 files changed, 24 insertions(+), 42 deletions(-)
> 14/15:
>  5 files changed, 66 deletions(-)
>
> Yeah, squashing them makes for a more impressive diffstat, while still
> not being too overwhelming with too much done in one patch.  I'm
> assuming you could handle the squashing as part of promoting to your
> qapi-next, if you want?

Can do.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]