[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 8/8] include: Clean up includes
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 8/8] include: Clean up includes |
Date: |
Thu, 18 Feb 2016 20:12:05 +0000 |
On 18 February 2016 at 19:54, Eric Blake <address@hidden> wrote:
> On 02/18/2016 11:05 AM, Peter Maydell wrote:
>> Clean up includes so that osdep.h is included first and headers
>> which it implies are not included manually.
>>
>> This commit was created with scripts/clean-includes.
>>
>> NB: If this commit breaks compilation for your out-of-tree
>> patchseries or fork, then you need to make sure you add
>> #include "qemu/osdep.h" to any new .c files that you have.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>
>> 97 files changed, 156 deletions(-)
>
>>
>> +++ b/include/migration/qemu-file.h
>> @@ -25,7 +25,6 @@
>> #define QEMU_FILE_H 1
>> #include "exec/cpu-common.h"
>>
>> -#include <stdint.h>
>>
>> /* This function writes a chunk of data to a file at the given position.
>
> Cleanups like this change the resulting whitespace in the file. I don't
> personally care, but I'm pointing it out in case someone does.
Oh, you mean we end up with two blank lines in a row? Yeah,
I don't care about that either :-)
thanks
-- PMM
- [Qemu-devel] [PATCH 0/8] more include cleaning, Peter Maydell, 2016/02/18
- [Qemu-devel] [PATCH 7/8] all: Clean up includes, Peter Maydell, 2016/02/18
- [Qemu-devel] [PATCH 8/8] include: Clean up includes, Peter Maydell, 2016/02/18
- [Qemu-devel] [PATCH 2/8] osdep.h: Define macros for the benefit of C++ before C++11, Peter Maydell, 2016/02/18
- [Qemu-devel] [PATCH 6/8] osdep.h: Include config-target.h if NEED_CPU_H is defined, Peter Maydell, 2016/02/18
- [Qemu-devel] [PATCH 3/8] disas/arm-a64.cc: Include osdep.h first, Peter Maydell, 2016/02/18
- [Qemu-devel] [PATCH 4/8] scripts/clean-includes: Enhance to handle header files, Peter Maydell, 2016/02/18