[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 5/8] target-arm/translate-a64.c: Use extract32 in
From: |
Edgar E. Iglesias |
Subject: |
[Qemu-devel] [PATCH v2 5/8] target-arm/translate-a64.c: Use extract32 in disas_ldst_reg_imm9 |
Date: |
Fri, 19 Feb 2016 21:04:49 +0100 |
From: "Edgar E. Iglesias" <address@hidden>
Use extract32 instead of open coding the bit masking when decoding
is_signed and is_extended. This streamlines the decoding with some
of the other ldst variants.
No functional change.
Reviewed-by: Sergey Fedorov <address@hidden>
Signed-off-by: Edgar E. Iglesias <address@hidden>
---
target-arm/translate-a64.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
index 7f65aea..bf31f8a 100644
--- a/target-arm/translate-a64.c
+++ b/target-arm/translate-a64.c
@@ -2117,8 +2117,8 @@ static void disas_ldst_reg_imm9(DisasContext *s, uint32_t
insn)
return;
}
is_store = (opc == 0);
- is_signed = opc & (1<<1);
- is_extended = (size < 3) && (opc & 1);
+ is_signed = extract32(opc, 1, 1);
+ is_extended = (size < 3) && extract32(opc, 0, 1);
}
switch (idx) {
--
1.9.1
- [Qemu-devel] [PATCH v2 0/8] arm: Steps towards EL2 support round 6, Edgar E. Iglesias, 2016/02/19
- [Qemu-devel] [PATCH v2 1/8] tcg: Add tcg_set_insn_param, Edgar E. Iglesias, 2016/02/19
- [Qemu-devel] [PATCH v2 2/8] gen-icount: Use tcg_set_insn_param, Edgar E. Iglesias, 2016/02/19
- [Qemu-devel] [PATCH v2 3/8] target-arm: Add the IL flag to syn_data_abort, Edgar E. Iglesias, 2016/02/19
- [Qemu-devel] [PATCH v2 5/8] target-arm/translate-a64.c: Use extract32 in disas_ldst_reg_imm9,
Edgar E. Iglesias <=
- [Qemu-devel] [PATCH v2 4/8] target-arm: Add more fields to the data abort syndrome generator, Edgar E. Iglesias, 2016/02/19
- [Qemu-devel] [PATCH v2 6/8] target-arm/translate-a64.c: Unify some of the ldst_reg decoding, Edgar E. Iglesias, 2016/02/19
- [Qemu-devel] [PATCH v2 7/8] target-arm: A64: Create Instruction Syndromes for Data Aborts, Edgar E. Iglesias, 2016/02/19
- [Qemu-devel] [PATCH v2 8/8] target-arm: Use isyn.swstep.ex to hold the is_ldex state, Edgar E. Iglesias, 2016/02/19