[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [V4 1/4] hw/i386: Introduce AMD IO MMU
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [V4 1/4] hw/i386: Introduce AMD IO MMU |
Date: |
Sun, 21 Feb 2016 09:16:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2016-02-17 20:09, David Kiarie wrote:
> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
> new file mode 100644
> index 0000000..4264c19
> --- /dev/null
> +++ b/hw/i386/amd_iommu.h
...
> +/* extended feature support */
> +#define IOMMU_EXT_FEATURES(IOMMU_FEATURE_PREFETCH | IOMMU_FEATURE_PPR | \
> + IOMMU_FEATURE_NX | IOMMU_FEATURE_IA | IOMMU_FEATURE_GT | \
> + IOMMU_FEATURE_GA | IOMMU_FEATURE_HE | IOMMU_GATS_MODE | \
> + IOMMU_HATS_MODE)
> +
> +/* capabilities header */
> +#define IOMMU_CAPAB_FEATURES(IOMMU_CAPAB_FLAT_EXT | \
> + IOMMU_CAPAB_FLAG_NPCACHE | \ IOMMU_CAPAB_FLAG_IOTLBSUP \
> + | IOMMU_CAPAB_ID_SEC | IOMMU_CAPAB_INIT_TYPE | \
> + IOMMU_CAPAB_FLAG_HTTUNNEL | IOMMU_CAPAB_EFR_SUP)
These two do not compile because you misformatted the macros. Must be
#define X (Y | Z | ...)
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [V4 0/4] AMD IOMMU, David Kiarie, 2016/02/17
- [Qemu-devel] [V4 2/4] hw/core: Add AMD IO MMU to machine properties, David Kiarie, 2016/02/17
- [Qemu-devel] [V4 3/4] hw/i386: ACPI table for AMD IO MMU, David Kiarie, 2016/02/17
- [Qemu-devel] [V4 1/4] hw/i386: Introduce AMD IO MMU, David Kiarie, 2016/02/17
- Re: [Qemu-devel] [V4 1/4] hw/i386: Introduce AMD IO MMU,
Jan Kiszka <=
- [Qemu-devel] [V4 4/4] hw/pci-host: Emulate AMD IO MMU, David Kiarie, 2016/02/17
- Re: [Qemu-devel] [V4 0/4] AMD IOMMU, Jan Kiszka, 2016/02/21