Re: [Qemu-devel] [PATCH 06/17] chardev: Drop useless ChardevDummy type

[Daniel P. Berrange]

On Fri, Feb 19, 2016 at 05:19:36PM -0700, Eric Blake wrote:
> Commit d0d7708b made ChardevDummy be an empty wrapper type around
> ChardevCommon.  But there is no technical reason for this indirection,
> so simplify the code by directly using the base type.
> 
> Also change the fallback assignment to assign u.null rather than
> u.data, since a future patch will remove the data member of the C
> struct generated for QAPI unions.
> 
> Signed-off-by: Eric Blake <address@hidden>
> ---
>  backends/baum.c    |  2 +-
>  backends/msmouse.c |  2 +-
>  qemu-char.c        |  6 +++---
>  qapi-schema.json   | 15 ++++++---------
>  4 files changed, 11 insertions(+), 14 deletions(-)

Reviewed-by: Daniel P. Berrange <address@hidden>

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|