Re: [Qemu-devel] [PATCH v3 1/1] quorum: modify vote rules for flush operation

[Alberto Garcia]

On Mon 22 Feb 2016 10:50:37 AM CET, Changlong Xie wrote:
> -    winner = quorum_get_vote_winner(&error_votes);
> -    result = winner->value.l;
> -
> +    if (success_count >= s->threshold)
> +        result = 0;
> +    else {
> +        winner = quorum_get_vote_winner(&error_votes);
> +        result = winner->value.l;
> +    }

Please use braces in both branches of the if. scripts/checkpatch.pl
should report that.

Other than that I think the patch is correct, but I still wonder if we
should emit QUORUM_REPORT_BAD (or a new event) for the operations that
fail. Or why wouldn't the user want to be notified of a flush failure?

Berto