[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/17] qapi: Add burst length parameters to b
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 10/17] qapi: Add burst length parameters to block_set_io_throttle |
Date: |
Mon, 22 Feb 2016 09:41:27 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 02/18/2016 03:27 AM, Alberto Garcia wrote:
> This patch adds the new bps_*_max_length and iops_*_max_length
> parameters to the block_set_io_throttle command.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> blockdev.c | 31 +++++++++++++++++++++++++++++++
> hmp.c | 12 ++++++++++++
> qapi/block-core.json | 51 +++++++++++++++++++++++++++++++++++++++++++++------
> qmp-commands.hx | 25 ++++++++++++++++---------
> 4 files changed, 104 insertions(+), 15 deletions(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index e8871fc..a5523ec 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -2590,6 +2590,18 @@ void qmp_block_set_io_throttle(const char *device,
> int64_t bps, int64_t bps_rd,
> int64_t iops_rd_max,
> bool has_iops_wr_max,
> int64_t iops_wr_max,
> + bool has_bps_max_length,
> + int64_t bps_max_length,
> + bool has_bps_rd_max_length,
> + int64_t bps_rd_max_length,
> + bool has_bps_wr_max_length,
> + int64_t bps_wr_max_length,
> + bool has_iops_max_length,
> + int64_t iops_max_length,
> + bool has_iops_rd_max_length,
> + int64_t iops_rd_max_length,
> + bool has_iops_wr_max_length,
> + int64_t iops_wr_max_length,
> bool has_iops_size,
> int64_t iops_size,
> bool has_group,
Not a problem with this patch, but your argument list is getting
painfully long; so we really want to simplify this once my boxed
parameters for commands lands:
https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04394.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 01/17] throttle: Make throttle_compute_timer() static, (continued)
- [Qemu-devel] [PATCH v2 01/17] throttle: Make throttle_compute_timer() static, Alberto Garcia, 2016/02/18
- [Qemu-devel] [PATCH v2 17/17] MAINTAINERS: Add myself as maintainer of the throttling code, Alberto Garcia, 2016/02/18
- [Qemu-devel] [PATCH v2 14/17] qemu-iotests: Extend iotest 093 to test bursts, Alberto Garcia, 2016/02/18
- [Qemu-devel] [PATCH v2 09/17] throttle: Add command-line settings to define the burst periods, Alberto Garcia, 2016/02/18
- [Qemu-devel] [PATCH v2 13/17] throttle: Test throttle_compute_wait() during bursts, Alberto Garcia, 2016/02/18
- [Qemu-devel] [PATCH v2 15/17] qapi: Correct the name of the iops_rd parameter, Alberto Garcia, 2016/02/18
- [Qemu-devel] [PATCH v2 08/17] throttle: Add support for burst periods, Alberto Garcia, 2016/02/18
- [Qemu-devel] [PATCH v2 05/17] throttle: Set always an average value when setting a maximum value, Alberto Garcia, 2016/02/18
- [Qemu-devel] [PATCH v2 06/17] throttle: Merge all functions that check the configuration into one, Alberto Garcia, 2016/02/18
- [Qemu-devel] [PATCH v2 10/17] qapi: Add burst length parameters to block_set_io_throttle, Alberto Garcia, 2016/02/18
- Re: [Qemu-devel] [PATCH v2 10/17] qapi: Add burst length parameters to block_set_io_throttle,
Eric Blake <=
- [Qemu-devel] [PATCH v2 11/17] qapi: Add burst length fields to BlockDeviceInfo, Alberto Garcia, 2016/02/18
- [Qemu-devel] [PATCH v2 16/17] docs: Document the throttling infrastructure, Alberto Garcia, 2016/02/18
- [Qemu-devel] [PATCH v2 03/17] throttle: Make throttle_max_is_missing_limit() set errp, Alberto Garcia, 2016/02/18
- Re: [Qemu-devel] [PATCH v2 00/17] throttle: Allow I/O bursts for a user-defined period of time, Kevin Wolf, 2016/02/22