[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-i386: fix confusion in xcr0 bit position
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-i386: fix confusion in xcr0 bit position vs. mask |
|
Date: |
Mon, 22 Feb 2016 11:14:44 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 02/22/2016 02:19 AM, Paolo Bonzini wrote:
> The xsave and xrstor helpers are accessing the x86_ext_save_areas array
> using a bit mask instead of a bit position. Provide two sets of XSTATE_*
> definitions and use XSTATE_*_BIT when a bit position is requested.
Whoops. This patch is fine,
Reviewed-by: Richard Henderson <address@hidden>
Dosen't Eduardo have a pending patch set to make xsave use a struct? That
would fix this as well, by not requiring fpu_helper.c to use the
x86_ext_save_areas array at all...
r~