Re: [Qemu-devel] [PATCH V4 0/2] net/filter-mirror:add filter-mirror and unit test

[Jason Wang]

On 02/18/2016 04:10 PM, Zhang Chen wrote:
> From: ZhangChen <address@hidden>
>
> Filter-mirror is a netfilter plugin.
> It gives qemu the ability to mirror
> packets to a chardev.
>
>
> v4:
>  - Address Jason's comments.
>
> v3:
>  - Add filter-mirror unit test according
>    to Jason's comments
>  - Address zhanghailiang's comments.
>  - Address Jason's comments.
>
> v2:
>  - Address zhanghailiang's comments.
>  - Address Eric Blake's comments.
>  - Address Yang Hongyang's comments.
>  - Address Dave's comments.
>
> v1:
>  initial patch.
>
>
> ZhangChen (2):
>   net/filter-mirror:Add filter-mirror
>   tests/test-filter-mirror:add filter-mirror unit test
>
>  net/Makefile.objs          |   1 +
>  net/filter-mirror.c        | 178 
> +++++++++++++++++++++++++++++++++++++++++++++
>  qemu-options.hx            |   4 +
>  tests/.gitignore           |   1 +
>  tests/Makefile             |   2 +
>  tests/test-filter-mirror.c |  89 +++++++++++++++++++++++
>  vl.c                       |   3 +-
>  7 files changed, 277 insertions(+), 1 deletion(-)
>  create mode 100644 net/filter-mirror.c
>  create mode 100644 tests/test-filter-mirror.c
>

Looks good overall. Just few nits, see individual patches.

Thanks