Re: [Qemu-devel] [PATCH v2 10/17] qapi: Add burst length parameters to block_set_io_throttle

[Alberto Garcia]

On Mon 22 Feb 2016 05:41:27 PM CET, Eric Blake <address@hidden> wrote:
>> @@ -2590,6 +2590,18 @@ void qmp_block_set_io_throttle(const char *device, 
>> int64_t bps, int64_t bps_rd,
>>                                 int64_t iops_rd_max,
>>                                 bool has_iops_wr_max,
>>                                 int64_t iops_wr_max,
>> +                               bool has_bps_max_length,
>> +                               int64_t bps_max_length,
>> +                               bool has_bps_rd_max_length,
>> +                               int64_t bps_rd_max_length,
>> +                               bool has_bps_wr_max_length,
>> +                               int64_t bps_wr_max_length,
>> +                               bool has_iops_max_length,
>> +                               int64_t iops_max_length,
>> +                               bool has_iops_rd_max_length,
>> +                               int64_t iops_rd_max_length,
>> +                               bool has_iops_wr_max_length,
>> +                               int64_t iops_wr_max_length,
>>                                 bool has_iops_size,
>>                                 int64_t iops_size,
>>                                 bool has_group,
>
> Not a problem with this patch, but your argument list is getting
> painfully long; so we really want to simplify this once my boxed
> parameters for commands lands:
> https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04394.html

I will be more than happy to do it :-) Thanks!

Berto