Re: [Qemu-devel] [PATCH v4 2/2] quorum: modify vote rules for flush operation

[Alberto Garcia]

On Tue 23 Feb 2016 10:01:39 AM CET, Changlong Xie wrote:
>      for (i = 0; i < s->num_children; i++) {
>          result = bdrv_co_flush(s->children[i]->bs);
> -        result_value.l = result;
> -        quorum_count_vote(&error_votes, &result_value, i);
> +        if (result) {
> +            quorum_flush_error(s->children[i]->bs->node_name, "Flush 
> failed");
> +            result_value.l = result;
> +            quorum_count_vote(&error_votes, &result_value, i);
> +        } else {
> +            success_count++;
> +        }

As I wrote on the review of patch 1/2, I would pass 'result' directly
instead of "Flush failed". Otherwise this patch looks good, thanks!

Berto