[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/2] move qcow2_invalidate_cache() out of cor
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/2] move qcow2_invalidate_cache() out of coroutine context |
Date: |
Wed, 24 Feb 2016 13:52:12 +0530 |
On (Tue) 23 Feb 2016 [18:49:00], Denis V. Lunev wrote:
> There is a possibility to hit an assert in qcow2_get_specific_info that
> s->qcow_version is undefined. This happens when VM in starting from
> suspended state, i.e. it processes incoming migration, and in the same
> time 'info block' is called.
>
> The problem is that qcow2_invalidate_cache() closes the image and
> memset()s BDRVQcowState in the middle.
>
> This operation should not be performed in coroutine context.
>
> Changes from v2:
> - subject lines in patches
Denis, did you see the comment by Fam to your patches?
Amit