Re: [Qemu-devel] [PATCH v3 0/2] move qcow2_invalidate_cache() out of coroutine context

[Denis V. Lunev]

On 02/24/2016 11:22 AM, Amit Shah wrote:
> On (Tue) 23 Feb 2016 [18:49:00], Denis V. Lunev wrote:
> > There is a possibility to hit an assert in qcow2_get_specific_info that
> > s->qcow_version is undefined. This happens when VM in starting from
> > suspended state, i.e. it processes incoming migration, and in the same
> > time 'info block' is called.
> >
> > The problem is that qcow2_invalidate_cache() closes the image and
> > memset()s BDRVQcowState in the middle.
> >
> > This operation should not be performed in coroutine context.
> >
> > Changes from v2:
> > - subject lines in patches
> Denis, did you see the comment by Fam to your patches?
>
>                 Amit
oops, I have seen it but have forgotten :( This should be fixed in a
perfect world. Though this code is called not frequently
and the amount of data lost is not that big.

OK, I'll rework this. Sorry :(