Re: [Qemu-devel] [PATCH 2/2] trace: separate MMIO tracepoints from TB-access tracepoints

[Stefan Hajnoczi]

On Wed, Feb 17, 2016 at 01:29:15PM -0800, Hollis Blanchard wrote:
> Memory accesses to code which has previously been translated into a TB show up
> in the MMIO path, so that they may invalidate the TB. It's extremely confusing
> to mix those in with device MMIOs, so split them into their own tracepoint.
> 
> Signed-off-by: Hollis Blanchard <address@hidden>
> 
> ---
> It took many hours to figure out why some RAM accesses were coming through the
> MMIO path instead of being handled inline in the TBs.
> 
> On IRC, Paolo expressed some concern about performance, but ultimately agreed
> that adding one conditional to an already heavy codepath wouldn't have much
> impact.
> ---
>  memory.c     | 25 +++++++++++++++++++++++++
>  trace-events |  2 ++
>  2 files changed, 27 insertions(+)

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature