[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/3] qmp event: Refactor QUORUM_REPORT_BAD
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 2/3] qmp event: Refactor QUORUM_REPORT_BAD |
Date: |
Wed, 24 Feb 2016 09:59:02 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 02/24/2016 03:11 AM, Changlong Xie wrote:
> Introduce QuorumOpType, and make QUORUM_REPORT_BAD compatible
> with it.
>
> Cc: Dr. David Alan Gilbert <address@hidden>
> Cc: Wen Congyang <address@hidden>
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: Changlong Xie <address@hidden>
> ---
> +++ b/docs/qmp-events.txt
> @@ -307,6 +307,7 @@ Emitted to report a corruption of a Quorum file.
>
> Data:
>
> +- "type": Quorum operation type (json-string, optional)
I don't think 'type' needs to be optional, after all. Just always
output it.
> - "error": Error message (json-string, optional)
> Only present on failure. This field contains a
> human-readable
> error message. There are no semantics other than that the
> @@ -318,10 +319,17 @@ Data:
>
> Example:
>
> +Read/Write operation:
> { "event": "QUORUM_REPORT_BAD",
> "data": { "node-name": "node0", "sector-num": 345435, "sectors-count":
> 5 },
> "timestamp": { "seconds": 1344522075, "microseconds": 745528 } }
and this example would then show "type":"read"
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature