Re: [Qemu-devel] [PATCH 1/4] slirp/slirp.h: Remove now-empty #ifdefs

[Thomas Huth]

On 23.02.2016 15:18, Peter Maydell wrote:
> After automatic cleanup to remove unnecessary #includes of headers that
> osdep.h provides, slirp.h has a few now unnecessary #ifdef/#endif pairs;
> remove them.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  slirp/slirp.h | 24 ------------------------
>  1 file changed, 24 deletions(-)
> 
> diff --git a/slirp/slirp.h b/slirp/slirp.h
> index 07c13b4..7cfcf63 100644
> --- a/slirp/slirp.h
> +++ b/slirp/slirp.h
...
> @@ -98,12 +80,6 @@ void free(void *ptr);
>  #include <ppp/slirppp.h>
>  #endif
>  
> -#ifdef __STDC__
> -#else
> -#include <varargs.h>
> -#endif

That else branch isn't really empty ... OTOH, QEMU likely does not
compile with a non-STDC-compliant compiler anyway, so I assume this is ok.

Reviewed-by: Thomas Huth <address@hidden>