[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] slirp/slirp.h: Remove now-empty #ifdefs
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] slirp/slirp.h: Remove now-empty #ifdefs |
Date: |
Wed, 24 Feb 2016 22:23:45 +0000 |
On 24 February 2016 at 18:58, Thomas Huth <address@hidden> wrote:
> On 23.02.2016 15:18, Peter Maydell wrote:
>> After automatic cleanup to remove unnecessary #includes of headers that
>> osdep.h provides, slirp.h has a few now unnecessary #ifdef/#endif pairs;
>> remove them.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>> slirp/slirp.h | 24 ------------------------
>> 1 file changed, 24 deletions(-)
>>
>> diff --git a/slirp/slirp.h b/slirp/slirp.h
>> index 07c13b4..7cfcf63 100644
>> --- a/slirp/slirp.h
>> +++ b/slirp/slirp.h
> ...
>> @@ -98,12 +80,6 @@ void free(void *ptr);
>> #include <ppp/slirppp.h>
>> #endif
>>
>> -#ifdef __STDC__
>> -#else
>> -#include <varargs.h>
>> -#endif
>
> That else branch isn't really empty ... OTOH, QEMU likely does not
> compile with a non-STDC-compliant compiler anyway, so I assume this is ok.
Indeed.
> Reviewed-by: Thomas Huth <address@hidden>
Thanks.
-- PMM
- [Qemu-devel] [PATCH 0/4] post-include-cleanup followups, Peter Maydell, 2016/02/23
- [Qemu-devel] [PATCH 1/4] slirp/slirp.h: Remove now-empty #ifdefs, Peter Maydell, 2016/02/23
- [Qemu-devel] [PATCH 4/4] util/base64.c: Clean includes, Peter Maydell, 2016/02/23
- [Qemu-devel] [PATCH 3/4] update-linux-headers.sh: Fake types.h doesn't need to include anything, Peter Maydell, 2016/02/23
- [Qemu-devel] [PATCH 2/4] include/config.h: Remove, Peter Maydell, 2016/02/23
- Re: [Qemu-devel] [PATCH 0/4] post-include-cleanup followups, Eric Blake, 2016/02/23