[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/2] move qcow2_invalidate_cache() out of cor
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/2] move qcow2_invalidate_cache() out of coroutine context |
Date: |
Thu, 25 Feb 2016 09:21:43 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, 02/24 11:53, Denis V. Lunev wrote:
> There is a possibility to hit an assert in qcow2_get_specific_info that
> s->qcow_version is undefined. This happens when VM in starting from
> suspended state, i.e. it processes incoming migration, and in the same
> time 'info block' is called.
>
> The problem is that qcow2_invalidate_cache() closes the image and
> memset()s BDRVQcowState in the middle.
>
> This operation should not be performed in coroutine context.
>
> Changes from v3:
> - added qemu_bh_delete at the end of BH to free allocated structure.
> Thanks to Fam.
Looks good to me now. Thanks!
Reviewed-by: Fam Zheng <address@hidden>