qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 2/3] qmp event: Refactor QUORUM_REPORT_BAD


From: Changlong Xie
Subject: Re: [Qemu-devel] [PATCH v5 2/3] qmp event: Refactor QUORUM_REPORT_BAD
Date: Thu, 25 Feb 2016 09:24:54 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 02/25/2016 09:12 AM, Eric Blake wrote:
On 02/24/2016 05:50 PM, Wen Congyang wrote:

+- "type":          Quorum operation type (json-string, optional)

I don't think 'type' needs to be optional, after all.  Just always
output it.

If we output read/write type, old libvirt will ignore the read/write error 
events?

The QMP protocol already documents that ALL clients MUST ignore
unexpected output fields.  Any client that is unprepared for new fields
appearing in the dictionary is buggy.  Libvirt will be just fine if you
output a new "type":"read".

Ok, i'll make "type" mandatory.

Thanks
        -Xie








reply via email to

[Prev in Thread] Current Thread [Next in Thread]