Re: [Qemu-devel] [PULL 0/9] qemu-ga patch queue for 2.6

[Peter Maydell]

On 25 February 2016 at 17:11, Michael Roth <address@hidden> wrote:
> The following changes since commit 774ae4254d3910f1c94ad6ed44d14cbea0e6a2f2:
>
>   Merge remote-tracking branch 
> 'remotes/bkoppelmann/tags/pull-tricore-20160225' into staging (2016-02-25 
> 12:57:22 +0000)
>
> are available in the git repository at:
>
>
>   git://github.com/mdroth/qemu.git tags/qga-pull-2016-02-25-tag
>
> for you to fetch changes up to e55eb806dbb97f53794b0c2f86983d34f6696845:
>
>   qga: fix w32 breakage due to missing osdep.h includes (2016-02-25 10:54:32 
> -0600)
>
> ----------------------------------------------------------------
> qemu-ga patch queue for 2.6
>
> * fix w32 build breakage when VSS enabled
> * fix up wchar handling in guest-set-user-password
> * fix re-install handling for w32 MSI installer
> * add w32 support for guest-get-vcpus
> * add support for enums in guest-file-seek SEEK params
>   instead of relying on platform-specific integer values

This doesn't seem to build on w32 (the old mingw compiler). It works
with the newer w64-mingw32 compiler so I guess this is just a
"disable stuff we can't support with the old headers" thing.

/home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c: In
function ‘qmp_guest_get_vcpus’:
/home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:1226:
error: ‘PSYSTEM_LOGICAL_PROCESSOR_INFORMATION’ undeclared (first use
in this function)
/home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:1226:
error: (Each undeclared identifier is reported only once
/home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:1226:
error: for each function it appears in.)
/home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:1226:
error: expected ‘;’ before ‘pslpi’
/home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:1232:
error: ‘ptr’ undeclared (first use in this function)
/home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:1232:
error: ‘pslpi’ undeclared (first use in this function)
cc1: warnings being treated as errors
/home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:1238:
warning: implicit declaration of function
‘GetLogicalProcessorInformation’
/home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:1238:
warning: nested extern declaration of ‘GetLogicalProcessorInformation’
/home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:1240:
error: ‘SYSTEM_LOGICAL_PROCESSOR_INFORMATION’ undeclared (first use in
this function)
/home/petmay01/linaro/qemu-for-merges/qga/commands-win32.c:1253:
error: ‘RelationProcessorCore’ undeclared (first use in this function)
make: *** [qga/commands-win32.o] Error 1
make: *** Waiting for unfinished jobs....
make: Leaving directory `/home/petmay01/linaro/qemu-for-merges/build/w32'

I'm open to the idea of dropping old-mingw from the build rotation
if it looks like it really is just totally hopeless, since I have
a newer setup for it now.

thanks
-- PMM