Re: [Qemu-devel] [PATCH] vhost-user: verify that number of queues is less than MAX_QUEUE_NUM

[Jason Wang]

On 02/24/2016 06:44 PM, Ilya Maximets wrote:
> Fix QEMU crash when -netdev vhost-user,queues=n is passed with number
> of queues greater than MAX_QUEUE_NUM.
>
> Signed-off-by: Ilya Maximets <address@hidden>
> ---
>  net/vhost-user.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/vhost-user.c b/net/vhost-user.c
> index 451dbbf..b753b3d 100644
> --- a/net/vhost-user.c
> +++ b/net/vhost-user.c
> @@ -317,9 +317,10 @@ int net_init_vhost_user(const NetClientOptions *opts, 
> const char *name,
>      }
>  
>      queues = vhost_user_opts->has_queues ? vhost_user_opts->queues : 1;
> -    if (queues < 1) {
> +    if (queues < 1 || queues > MAX_QUEUE_NUM) {
>          error_setg(errp,
> -                   "vhost-user number of queues must be bigger than zero");
> +                   "vhost-user number of queues must be in range [1, %d]",
> +                   MAX_QUEUE_NUM);
>          return -1;
>      }
>  

Acked-by: Jason Wang <address@hidden>