[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 8/9] qemu-log: support simple pid substitutio
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v7 8/9] qemu-log: support simple pid substitution for logs |
Date: |
Fri, 26 Feb 2016 12:21:23 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 02/22/2016 07:59 AM, Alex Bennée wrote:
> When debugging stuff that occurs over several forks it would be useful
> not to keep overwriting the one logfile you've set-up. This allows a
> simple %d to be included once in the logfile parameter which is
> substituted with getpid().
>
> As the test cases involve checking user output they need
> g_test_trap_subprocess() support. As a result they are currently skipped
> on Travis builds due to the older glib involved.
>
> Signed-off-by: Alex Bennée <address@hidden>
> Reviewed-by: Leandro Dorileo <address@hidden>
> Reviewed-by: Aurelien Jarno <address@hidden>
>
> ---
> v5
> - add another r-b
> v7
> - simpler error check as suggested by Eric Blake
> - don't g_error, just error_report (so we don't crash from monitor)
> - add some unit tests
> ---
> tests/test-logging.c | 39 +++++++++++++++++++++++++++++++++++++++
> util/log.c | 22 ++++++++++++++++++++--
> 2 files changed, 59 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH v7 3/9] qemu-log: Avoid function call for disabled qemu_log_mask logging, (continued)
- [Qemu-devel] [PATCH v7 3/9] qemu-log: Avoid function call for disabled qemu_log_mask logging, Alex Bennée, 2016/02/22
- [Qemu-devel] [PATCH v7 4/9] qemu-log: Improve the "exec" TB execution logging, Alex Bennée, 2016/02/22
- [Qemu-devel] [PATCH v7 1/9] tcg: pass down TranslationBlock to tcg_code_gen, Alex Bennée, 2016/02/22
- [Qemu-devel] [PATCH v7 6/9] qemu-log: dfilter-ise exec, out_asm, op and opt_op, Alex Bennée, 2016/02/22
- [Qemu-devel] [PATCH v7 7/9] target-arm: dfilter support for in_asm, Alex Bennée, 2016/02/22
- [Qemu-devel] [PATCH v7 5/9] qemu-log: new option -dfilter to limit output, Alex Bennée, 2016/02/22
- [Qemu-devel] [PATCH v7 8/9] qemu-log: support simple pid substitution for logs, Alex Bennée, 2016/02/22
- Re: [Qemu-devel] [PATCH v7 8/9] qemu-log: support simple pid substitution for logs,
Richard Henderson <=
- [Qemu-devel] [PATCH v7 9/9] cputlb: modernise the debug support, Alex Bennée, 2016/02/22
- Re: [Qemu-devel] [PATCH v7 0/9] qemu-log, -dfilter and other logging tweaks, Alex Bennée, 2016/02/26