[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 14/19] log: Redirect stderr to logfile if deamoni
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 14/19] log: Redirect stderr to logfile if deamonized |
Date: |
Mon, 29 Feb 2016 10:07:47 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 29/02/2016 09:57, Ján Tomko wrote:
> qemu-system-x86_64 -S -no-user-config -nodefaults -nographic -M none
> -qmp unix:/var/lib/libvirt/qemu/capabilities.monitor.sock,server,nowait
> -pidfile /var/lib/libvirt/qemu/capabilities.pidfile -daemonize
Can you test this patch?
diff --git a/util/log.c b/util/log.c
index 4dff00b..9402880 100644
--- a/util/log.c
+++ b/util/log.c
@@ -56,7 +56,8 @@ void do_qemu_set_log(int log_flags, bool use_own_buffers)
#ifdef CONFIG_TRACE_LOG
qemu_loglevel |= LOG_TRACE;
#endif
- if ((qemu_loglevel || is_daemonized()) && !qemu_logfile) {
+ if (!qemu_logfile &&
+ (qemu_loglevel || (is_daemonized() && logfilename)) {
if (logfilename) {
qemu_logfile = fopen(logfilename, log_append ? "a" : "w");
if (!qemu_logfile) {
Thanks,
Paolo
- [Qemu-devel] [PULL 03/19] dump-guest-memory: cleanup: removing dump_{error|cleanup}()., (continued)
- [Qemu-devel] [PULL 03/19] dump-guest-memory: cleanup: removing dump_{error|cleanup}()., Paolo Bonzini, 2016/02/24
- [Qemu-devel] [PULL 08/19] dump-guest-memory: disable dump when in INMIGRATE state, Paolo Bonzini, 2016/02/24
- [Qemu-devel] [PULL 09/19] dump-guest-memory: add "detach" support, Paolo Bonzini, 2016/02/24
- [Qemu-devel] [PULL 07/19] dump-guest-memory: introduce dump_process() helper function., Paolo Bonzini, 2016/02/24
- [Qemu-devel] [PULL 06/19] dump-guest-memory: add dump_in_progress() helper function, Paolo Bonzini, 2016/02/24
- [Qemu-devel] [PULL 10/19] DumpState: adding total_size and written_size fields, Paolo Bonzini, 2016/02/24
- [Qemu-devel] [PULL 12/19] Dump: add hmp command "info dump", Paolo Bonzini, 2016/02/24
- [Qemu-devel] [PULL 11/19] Dump: add qmp command "query-dump", Paolo Bonzini, 2016/02/24
- [Qemu-devel] [PULL 14/19] log: Redirect stderr to logfile if deamonized, Paolo Bonzini, 2016/02/24
[Qemu-devel] [PULL 13/19] dump-guest-memory: add qmp event DUMP_COMPLETED, Paolo Bonzini, 2016/02/24
[Qemu-devel] [PULL 16/19] memory: optimize qemu_get_ram_ptr and qemu_ram_ptr_length, Paolo Bonzini, 2016/02/24
[Qemu-devel] [PULL 17/19] memory: Remove unreachable return statement, Paolo Bonzini, 2016/02/24
[Qemu-devel] [PULL 18/19] chardev: Properly initialize ChardevCommon components, Paolo Bonzini, 2016/02/24
[Qemu-devel] [PULL 15/19] exec: store RAMBlock pointer into memory region, Paolo Bonzini, 2016/02/24