[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PING][PATCH] Use unsigned types for the 'len' argument
From: |
Martin Galvan |
Subject: |
Re: [Qemu-devel] [PING][PATCH] Use unsigned types for the 'len' argument of all memory read/write functions |
Date: |
Mon, 29 Feb 2016 12:28:06 -0300 |
On Mon, Feb 29, 2016 at 11:59 AM, Paolo Bonzini <address@hidden> wrote:
> Hi Martin,
>
> despite the apparent simplicity, this patch is very hard to review. I
> suggest splitting it in several parts so that the various submaintainers
> can look at it. I can take a look at cpus.c, exec.c, kvm-all.c and
> include/exec/, for example.
>
> Please use size_t instead of hwaddr to refer to the size of a buffer in
> host memory, for example address_space_rw's buf argument.
Ok, will do. Thanks for the response!