Re: [Qemu-devel] [PATCH 08/38] ivshmem: Rewrite specification document

[Eric Blake]

On 02/29/2016 11:40 AM, Markus Armbruster wrote:
> This started as an attempt to update ivshmem_device_spec.txt for
> clarity, accuracy and completeness while working on its code, and
> quickly became a full rewrite.  Since the diff would be useless
> anyway, I'm using the opportunity to rename the file to
> ivshmem-spec.txt.
> 
> I tried hard to ensure the new text contradicts neither the old text
> nor the code.  If the new text contradicts the old text but not the
> code, it's probably a bug in the old text.  If the new text
> contradicts both, its probably a bug in the new text.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---

> +If the server terminates without sending disconnect notifications for
> +its connected clients, the clients can elect to continue.  They can
> +communicate with each other normally, but won't receive disconnect
> +notification on disconnect, and no new clients can connect.  There is
> +no way for the clients to connect to a restarted the server.  The

s/the server/server/

> +device is not capable to tell guest software whether the server is
> +still up.

Wow - lots of shortcomings in the server protocol.  Food for thought for
future improvements, but I'm happy with your approach of just
documenting pitfalls for now.

> +
> +Known bugs:
> +
> +* The protocol changed incompatibly in QEMU 2.5.  Before, messages
> +  were native endian long, and there was no version number.
> +
> +* The protocol is poorly designed.


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature