[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/13] Use unsigned types for the 'len' argum
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/13] Use unsigned types for the 'len' argument of all memory read/write functions |
Date: |
Tue, 1 Mar 2016 09:05:35 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/01/2016 08:57 AM, Martin Galvan wrote:
Missing a S-o-b line; we cannot accept patches unless you sign them:
http://wiki.qemu.org/Contribute/SubmitAPatch
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2a#n297
Subject line is long, and lacking a 'topic: summary' prefix. I'd suggest:
mem: use unsigned 'len' for read/write
Then give more details, if needed, in the body of the commit message.
Also, your threading didn't work right. Patch 1/13 was sent with:
References:
<address@hidden>
but with no In-Reply-To:. Meanwhile, the 00/13 cover letter was sent with:
Message-Id:
<address@hidden>
which is subtly different from the references of all the other patches,
making it appear as separate threads.
> ---
> cpus.c | 2 +-
> exec.c | 29 +++++++++++++++--------------
> include/exec/cpu-all.h | 2 +-
> include/exec/cpu-common.h | 10 +++++-----
> include/exec/memory.h | 10 +++++-----
> kvm-all.c | 2 +-
> 6 files changed, 28 insertions(+), 27 deletions(-)
>
> diff --git a/cpus.c b/cpus.c
> index 9592163..e7aa8cc 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -1602,7 +1602,7 @@ void qmp_memsave(int64_t addr, int64_t size, const char
> *filename,
> bool has_cpu, int64_t cpu_index, Error **errp)
> {
> FILE *f;
> - uint32_t l;
> + size_t l;
These are both unsigned types. So based on the subject line alone, this
doesn't fit in the patch, unless the commit message body goes into more
details on why you are changing the size of the type, and not just the
signedness.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 04/13] Use unsigned types for the 'len' argument of all memory read/write functions, (continued)
- [Qemu-devel] [PATCH v2 04/13] Use unsigned types for the 'len' argument of all memory read/write functions, Martin Galvan, 2016/03/01
- [Qemu-devel] [PATCH v2 05/13] Use unsigned types for the 'len' argument of all memory read/write functions, Martin Galvan, 2016/03/01
- [Qemu-devel] [PATCH v2 06/13] Use unsigned types for the 'len' argument of all memory read/write functions, Martin Galvan, 2016/03/01
- [Qemu-devel] [PATCH v2 07/13] Use unsigned types for the 'len' argument of all memory read/write functions, Martin Galvan, 2016/03/01
- [Qemu-devel] [PATCH v2 08/13] Use unsigned types for the 'len' argument of all memory read/write functions, Martin Galvan, 2016/03/01
- [Qemu-devel] [PATCH v2 09/13] Use unsigned types for the 'len' argument of all memory read/write functions, Martin Galvan, 2016/03/01
- [Qemu-devel] [PATCH v2 10/13] Use unsigned types for the 'len' argument of all memory read/write functions, Martin Galvan, 2016/03/01
- [Qemu-devel] [PATCH v2 11/13] Use unsigned types for the 'len' argument of all memory read/write functions, Martin Galvan, 2016/03/01
- [Qemu-devel] [PATCH v2 12/13] Use unsigned types for the 'len' argument of all memory read/write functions, Martin Galvan, 2016/03/01
- [Qemu-devel] [PATCH v2 13/13] Use unsigned types for the 'len' argument of all memory read/write functions, Martin Galvan, 2016/03/01
- Re: [Qemu-devel] [PATCH v2 01/13] Use unsigned types for the 'len' argument of all memory read/write functions,
Eric Blake <=