[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-i386: avoid repeated calls to the bnd_jm
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-i386: avoid repeated calls to the bnd_jmp helper |
|
Date: |
Tue, 1 Mar 2016 08:28:07 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/01/2016 07:12 AM, Paolo Bonzini wrote:
> One flag was tested the wrong way.
>
> Cc: address@hidden
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> target-i386/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/translate.c b/target-i386/translate.c
> index b345e2c..ebd8995 100644
> --- a/target-i386/translate.c
> +++ b/target-i386/translate.c
> @@ -2420,7 +2420,7 @@ static void gen_bnd_jmp(DisasContext *s)
> itself will check BNDPRESERVE at runtime. */
> if ((s->prefix & PREFIX_REPNZ) == 0
> && (s->flags & HF_MPX_EN_MASK) == 0
> - && (s->flags & HF_MPX_IU_MASK) == 0) {
> + && (s->flags & HF_MPX_IU_MASK) != 0) {
Ho hum. Two flags tested the wrong way -- EN_MASK should be on as well.
r~