[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-i386: fix smsw and lmsw from/to register
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH] target-i386: fix smsw and lmsw from/to register |
Date: |
Tue, 1 Mar 2016 08:34:17 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/01/2016 07:12 AM, Paolo Bonzini wrote:
> SMSW and LMSW accept register operands, but commit 1906b2a ("target-i386:
> Rearrange processing of 0F 01", 2016-02-13) did not account for that.
>
> Fixes: 1906b2af7c2345037d9b2fdf484b457b5acd09d1
> Cc: address@hidden
> Reported-by: Hervé Poussineau <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> target-i386/translate.c | 38 ++++++++++++++++++++++----------------
> 1 file changed, 22 insertions(+), 16 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
Sorry about that. As recompense, I just noticed that we're not implementing
these instructions properly for 64-bit mode. I'll post a patch for that as
well.
r~