Re: [Qemu-devel] [PATCH 15/38] ivshmem: Failed realize() can leave migration blocker behind

[Marc-André Lureau]

Hi

On Wed, Mar 2, 2016 at 10:54 AM, Markus Armbruster <address@hidden> wrote:
>>> -        create_shared_memory_BAR(s, fd, attr, errp);
>>> +        create_shared_memory_BAR(s, fd, attr, &err);
>>> +        if (err) {
>>> +            error_propagate(errp, err);
>>> +            return;
>>> +        }
>
> Before my patch, passing errp to create_shared_memory_BAR() was fine,
> because it was the last thing the function does.
>
> Now, it isn't: we must bypass the rest of the function on error.
>
> All clear now?


Got it, thanks.

-- 
Marc-André Lureau