Re: [Qemu-devel] [PATCH v2 11/19] qapi: Add type.is_empty() helper

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 03/02/2016 12:04 PM, Markus Armbruster wrote:
>> Eric Blake <address@hidden> writes:
>> 
>>> And use it in qapi-types and qapi-event.  Down the road, we may
>>> want to lift our artificial restriction of no variants at the
>>> top level of an event, at which point, inlining our check for
>>> whether members is empty will no longer be sufficient, but
>>> adding a check for variants adds verbosity; in the meantime,
>>> add some asserts in places where we don't handle variants.
>> 
>> Perhaps I'm just running out of steam for today, but I've read this
>> twice, and still don't get why adding these assertions goes in the same
>> patch as adding the helper, or what it has to do with events.
>
> Okay, will split this into two patches for v3.

A better commit message might do.  Use your judgement.