qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] correct comment of MemoryHotplugState


From: Cao jin
Subject: [Qemu-devel] [PATCH] correct comment of MemoryHotplugState
Date: Thu, 3 Mar 2016 17:24:12 +0800

correct comment and remove an unused macro. commit adcb4ee6 already
correct its type

Signed-off-by: Cao jin <address@hidden>
---
Btw, in pc_memory_init(), I don`t see in which condition, the following code
will be executed:

    if ((pcms->hotplug_memory.base + hotplug_mem_size) <
        hotplug_mem_size) {
        error_report("unsupported amount of maximum memory: " RAM_ADDR_FMT,
                      machine->maxram_size);
        exit(EXIT_FAILURE);
    }

I appreciate if anyone could give a hint

And PS: the output of *get_maintainer.pl this_patch* isn`t the same as
*get_maintainer.pl -f include/hw/mem/pc-dimm.h*.
I am not sure if it is a problem.

 include/hw/mem/pc-dimm.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
index 218dfb0..8cdc326 100644
--- a/include/hw/mem/pc-dimm.h
+++ b/include/hw/mem/pc-dimm.h
@@ -20,8 +20,6 @@
 #include "sysemu/hostmem.h"
 #include "hw/qdev.h"
 
-#define DEFAULT_PC_DIMMSIZE (1024*1024*1024)
-
 #define TYPE_PC_DIMM "pc-dimm"
 #define PC_DIMM(obj) \
     OBJECT_CHECK(PCDIMMDevice, (obj), TYPE_PC_DIMM)
@@ -72,7 +70,7 @@ typedef struct PCDIMMDeviceClass {
 
 /**
  * MemoryHotplugState:
- * @base: address in guest RAM address space where hotplug memory
+ * @base: address in guest physical address space where hotplug memory
  * address space begins.
  * @mr: hotplug memory address space container
  */
-- 
2.1.0






reply via email to

[Prev in Thread] Current Thread [Next in Thread]