Re: [Qemu-devel] [PATCH v3 0/4] rng-random: implement request queue

[Amit Shah]

On (Thu) 03 Mar 2016 [09:37:14], Ladi Prosek wrote:
> As suggested by Paolo, I have moved the RngRequest implementation
> up to the RngBackend parent class and made both child classes use
> it. Apart from the refactoring, the only functional change
> compared to v1 is the use of heap instead of stack allocation for
> the read buffer in rng-random.
> 
> The parent class takes care of creating new requests and adding
> them to the queue, as well as removing them from the queue and
> deleting them. Child classes have access to the raw GSList * to
> do whatever else they need to do (walk the queue, peek the head
> of the queue, ..)
> 
> Changes from v2:
> - updated commit message in 1/4 and 4/4 as requested by Amit

Reviewed-by: Amit Shah <address@hidden>

Thanks,

                Amit