qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 5/9] qemu-log: new option -dfilter to limit o


From: Alex Bennée
Subject: Re: [Qemu-devel] [PATCH v7 5/9] qemu-log: new option -dfilter to limit output
Date: Thu, 03 Mar 2016 14:04:24 +0000
User-agent: mu4e 0.9.17; emacs 25.0.91.6

Richard Henderson <address@hidden> writes:

> On 02/22/2016 07:59 AM, Alex Bennée wrote:
>> +    qemu_set_dfilter_ranges("0x1000+0x100");
>> +
>> +    g_assert_false(qemu_log_in_addr_range(0xfff));
>> +    g_assert(qemu_log_in_addr_range(0x1000));
>> +    g_assert(qemu_log_in_addr_range(0x1100));
>
> This is exactly what I was talking about wrt off-by-one error in my first
> review -- 0x100 bytes, including 0x1000, finishes at 0x10ff.
>
> This third test should fail.

OK so should 0x100+0x0 fail as it makes no sense, 0 bytes from 0x100 start?

>
>
> r~


--
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]