qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 2/3] qmp event: Refactor QUORUM_REPORT_BAD


From: Alberto Garcia
Subject: Re: [Qemu-devel] [PATCH v7 2/3] qmp event: Refactor QUORUM_REPORT_BAD
Date: Thu, 03 Mar 2016 15:48:13 +0100
User-agent: Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu)

>> +Read operation:
>>  { "event": "QUORUM_REPORT_BAD",
>> -     "data": { "node-name": "node0", "sector-num": 345435, "sectors-count": 
>> 5 },
>> +     "data": { "node-name": "node0", "sector-num": 345435, "sectors-count": 
>> 5,
>> +               "type": "read" },
>>       "timestamp": { "seconds": 1344522075, "microseconds": 745528 } }
>>  
>> +Flush operation:
>> +{ "event": "QUORUM_REPORT_BAD",
>> +     "data": { "node-name": "node0", "sector-num": 0, "sectors-count": 
>> 2097120,
>> +               "type": "flush", "error": "Broken pipe" },
>> +     "timestamp": { "seconds": 1456406829, "microseconds": 291763 } }
>> +
>>  Note: this event is rate-limited.
>
> Question - do we care if rate limiting masks one type of failure due
> to another?  Or put another way, are we okay with a single
> rate-limiting queue for all three types, or do we want three queues?
> Also, shouldn't this have a queue per child node (I don't want to be
> flooded with multiple notifications in one second that child1 has
> failed, but I _do_ want notifications if both child1 and child2 fail
> in the same second).

I think you are right, thanks for pointing it out.

Berto



reply via email to

[Prev in Thread] Current Thread [Next in Thread]