[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager t
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt |
Date: |
Thu, 3 Mar 2016 15:53:48 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/03/2016 15:47, Denis V. Lunev wrote:
>>
> ok, you are finally right. Your original code is correct and will
> work even in these corner case.
>
> Will it make sense to send a patch which will replace that code
> to my one as followup + fix if 'fopen' will fail?
Definitely. While at it, you could move qemu_log_close and
qemu_log_flush from the header to the C file. They are in the header
only for very historical reasons; exec.c in the past could only invoke a
limited amount of external code, but luckily that's not the case anymore.
Paolo
- [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt, Denis V. Lunev, 2016/03/03
- Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt, Paolo Bonzini, 2016/03/03
- Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt, Denis V. Lunev, 2016/03/03
- Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt, Paolo Bonzini, 2016/03/03
- Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt, Denis V. Lunev, 2016/03/03
- Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt, Paolo Bonzini, 2016/03/03
- Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt, Denis V. Lunev, 2016/03/03
- Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt, Paolo Bonzini, 2016/03/03
- Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt, Denis V. Lunev, 2016/03/03
- Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 1/1] log: fix hanged connect from virt-manager to libvirt, Denis V. Lunev, 2016/03/03